Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #67
I thought this PR would be easy, but there are some issues:
shouldShowPrompt
function directly from thesrc/
directory instead. Not ideal, but it might be OK.shouldShowPrompt
function will be called twice: once by the developer to determine whether to import the rest of the library, and once by the library to determine whether to show the prompt. This would be fine, except the function has side-effects: it increments thevisits
counter on each call, meaning that the prompt might be shown too soon or not at all. This is breaking.What are your thoughts on this, @chrisdancee?