Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facilitate code-splitting #68

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,3 +55,31 @@ import PWAPrompt from 'react-ios-pwa-prompt'
```
<PWAPrompt promptOnVisit={1} timesToShow={3} copyClosePrompt="Close" permanentlyHideOnDismiss={false}/>
```

## Code-splitting

You may want to use [code-splitting](https://reactjs.org/docs/code-splitting.html) to avoid unnecessarily loading the component (including styles and icons) when it isn't going to be shown.
Use the exported `shouldShowPrompt` function to determine whether to import the component, for example:

```jsx
import shouldShowPrompt from "react-ios-pwa-prompt/src/shouldShowPrompt";

const LazyPWAPrompt = React.lazy(() => import("react-ios-pwa-prompt"));

function render() {
const options = {
timesToShow: 1,
promptOnVisit: 2,
};

if (shouldShowPrompt(options)) {
return (
<Suspense fallback={null}>
<LazyPWAPrompt {...options} />
</Suspense>
);
}

return null;
}
```
2 changes: 1 addition & 1 deletion dist/react-ios-pwa-prompt.js

Large diffs are not rendered by default.

67 changes: 18 additions & 49 deletions src/index.js
Original file line number Diff line number Diff line change
@@ -1,19 +1,8 @@
import React from "react";

import shouldShowPrompt from "./shouldShowPrompt";
import PWAPrompt from "./components/PWAPrompt";

const deviceCheck = () => {
const isiOS = /iphone|ipad|ipod/.test(
window.navigator.userAgent.toLowerCase()
);
const isiPadOS =
navigator.platform === "MacIntel" && navigator.maxTouchPoints > 1;
const isStandalone =
"standalone" in window.navigator && window.navigator.standalone;

return (isiOS || isiPadOS) && !isStandalone;
};

export default ({
timesToShow = 1,
promptOnVisit = 1,
Expand All @@ -27,43 +16,23 @@ export default ({
debug = false,
onClose = () => {},
}) => {
let promptData = JSON.parse(localStorage.getItem("iosPwaPrompt"));

if (promptData === null) {
promptData = { isiOS: deviceCheck(), visits: 0 };
localStorage.setItem("iosPwaPrompt", JSON.stringify(promptData));
}

if (promptData.isiOS || debug) {
const aboveMinVisits = promptData.visits + 1 >= promptOnVisit;
const belowMaxVisits = promptData.visits + 1 < promptOnVisit + timesToShow;

if (belowMaxVisits || debug) {
localStorage.setItem(
"iosPwaPrompt",
JSON.stringify({
...promptData,
visits: promptData.visits + 1,
})
);

if (aboveMinVisits || debug) {
return (
<PWAPrompt
delay={delay}
copyTitle={copyTitle}
copyBody={copyBody}
copyAddHomeButtonLabel={copyAddHomeButtonLabel}
copyShareButtonLabel={copyShareButtonLabel}
copyClosePrompt={copyClosePrompt}
permanentlyHideOnDismiss={permanentlyHideOnDismiss}
promptData={promptData}
maxVisits={timesToShow + promptOnVisit}
onClose={onClose}
/>
);
}
}
if (shouldShowPrompt({ timesToShow, promptOnVisit, debug })) {
const promptData = JSON.parse(localStorage.getItem("iosPwaPrompt"));

return (
<PWAPrompt
delay={delay}
copyTitle={copyTitle}
copyBody={copyBody}
copyAddHomeButtonLabel={copyAddHomeButtonLabel}
copyShareButtonLabel={copyShareButtonLabel}
copyClosePrompt={copyClosePrompt}
permanentlyHideOnDismiss={permanentlyHideOnDismiss}
promptData={promptData}
maxVisits={timesToShow + promptOnVisit}
onClose={onClose}
/>
)
}

return null;
Expand Down
45 changes: 45 additions & 0 deletions src/shouldShowPrompt.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
function deviceCheck() {
const isiOS = /iphone|ipad|ipod/.test(
window.navigator.userAgent.toLowerCase()
);
const isiPadOS =
navigator.platform === "MacIntel" && navigator.maxTouchPoints > 1;
const isStandalone =
"standalone" in window.navigator && window.navigator.standalone;

return (isiOS || isiPadOS) && !isStandalone;
}

export default function shouldShowPrompt({
timesToShow = 1,
promptOnVisit = 1,
debug = false,
}) {
let promptData = JSON.parse(localStorage.getItem("iosPwaPrompt"));

if (promptData === null) {
promptData = { isiOS: deviceCheck(), visits: 0 };
localStorage.setItem("iosPwaPrompt", JSON.stringify(promptData));
}

if (promptData.isiOS || debug) {
const aboveMinVisits = promptData.visits + 1 >= promptOnVisit;
const belowMaxVisits = promptData.visits + 1 < promptOnVisit + timesToShow;

if (belowMaxVisits || debug) {
localStorage.setItem(
"iosPwaPrompt",
JSON.stringify({
...promptData,
visits: promptData.visits + 1,
})
);

if (aboveMinVisits || debug) {
return true;
}
}
}

return false;
}