Fix npm#2033 Always accept url deps as valid

chrisdew · Apr 12, 2012 · 6a8002f · 6a8002f
1 parent 4bea5b0
commit 6a8002f
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/lib/utils/read-installed.js b/lib/utils/read-installed.js
@@ -94,6 +94,7 @@ var npm = require("../npm.js")
   , semver = require("semver")
   , readJson = require("./read-json.js")
   , log = require("./log.js")
+  , url = require("url")
 
 module.exports = readInstalled
 
@@ -254,6 +255,8 @@ function findUnmet (obj) {
           continue
         }
         if ( typeof deps[d] === "string"
+            // url deps presumed innocent.
+            && !url.parse(deps[d]).protocol
             && !semver.satisfies(found.version, deps[d])) {
           // the bad thing will happen
           log.warn(obj.path + " requires "+d+"@'"+deps[d]