Fix pre-commit and RTD build #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The older version fails during install for newer versions of poetry.
Add the new required `build.os` key and fix it to Ubuntu 22.04
|
@chrisjsewell this fixes two issues with the CI pipeline, however, tests are still failing. Seems like some dependency down-stream got a new release which causes the diffs to be different. For some reason the md5s of images are getting changed and I have no idea who is responsible for writing this output or where it is being written: ## replaced /cells/13/outputs/0/data/image/png:
- iVBORw0K...<snip base64, md5=f94a82072d4a539b...>
+ iVBORw0K...<snip base64, md5=d4cb03e0b7c8a788...>
## replaced /cells/14/outputs/0/data/image/jpeg:
- /9j/4AAQ...<snip base64, md5=780504154e4118c5...>
+ /9j/4AAQ...<snip base64, md5=63dc79d972a66eab...>
## replaced /cells/15/outputs/0/data/image/png:
- iVBORw0K...<snip base64, md5=f94a82072d4a539b...>
+ iVBORw0K...<snip base64, md5=d4cb03e0b7c8a788...>
## replaced /cells/15/outputs/3/data/image/jpeg:
- /9j/4AAQ...<snip base64, md5=780504154e4118c5...>
+ /9j/4AAQ...<snip base64, md5=63dc79d972a66eab...>Any ideas? |
|
@chrisjsewell just a quick ping. This is blocking a number of packages to release a Python 3.12 compatible version. Could you please have a look? Thanks! |
|
all fixed cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.