Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pkg_resources with importlib_metadata #44

Closed
ErikBjare opened this issue Nov 8, 2023 · 2 comments
Closed

Replace pkg_resources with importlib_metadata #44

ErikBjare opened this issue Nov 8, 2023 · 2 comments

Comments

@ErikBjare
Copy link

ErikBjare commented Nov 8, 2023

The plugin caused my tests to not start, as pkg_resources was not available (no setuptools).

It's used for pkg_resources.iter_entry_points(): https://github.com/search?q=repo%3Achrisjsewell%2Fpytest-notebook%20pkg_resources&type=code

It's fair to say it is deprecated (and unavailable without setuptools), and replaced by importlib.

However, the importlib_metadata package is needed to backport it for Python <3.10 (importlib.metadata.entry_points was added in 3.10).

Here's a couple random issues describing why:

@sphuber
Copy link
Contributor

sphuber commented Nov 9, 2023

I addressed this problem in this PR: https://github.com/chrisjsewell/pytest-notebook/pull/41/files
Except the tests are failing for other reasons. I opened another PR to address those as well: #42
There are just a few outstanding failures that I do not know how to address and would need support from @chrisjsewell

@chrisjsewell
Copy link
Owner

closed in #41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants