Add "Xcode" directory #270
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create an "Xcode" directory and copy the current contents of the "Xcode 4" directory to it. Previously, the "Xcode 4" directory was the only Xcode-related directory in the repo, which is misleading because the themes contained in it also work fine in Xcode 6 (beta 5). Other projects (e.g., Alcatraz) use URLs that link directly to the existing themes in the "Xcode 4" directory, so instead of removing the "Xcode 4" directory and breaking everything that might be linking to those themes, I propose we leave it for now. Moving forward, instead of supporting each version of Xcode by creating an separate "Xcode <version>" directory -- which wasn't done for Xcode 5 or Xcode 6 -- I propose there be a single "Xcode" directory that supports the latest version of Xcode.
|
Looks like you forgot to add the deletion (that is, renaming) of the old directory. |
|
Based on my initial comments, it looks like I intentionally chose to not delete the old directory (Xcode 4):
|
|
Oh, misread that. Sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create an "Xcode" directory and copy the current contents of the
"Xcode 4" directory to it.
Previously, the "Xcode 4" directory was the only Xcode-related
directory in the repo, which is misleading because the themes
contained in it also work fine in Xcode 6 (beta 5).
Other projects (e.g., Alcatraz) use URLs that link directly to the
existing themes in the "Xcode 4" directory, so instead of removing the
"Xcode 4" directory and breaking everything that might be linking to
those themes, I propose we leave it for now.
Moving forward, instead of supporting each version of Xcode by creating
an separate "Xcode " directory -- which wasn't done for
Xcode 5 or Xcode 6 -- I propose there be a single "Xcode" directory
that supports the latest version of Xcode.