missing Luminary099 files retrieved from virtualagc at https://github…

[proudindiv]

Here are the 51 missing Luminary099 files retrieved from virtualagc at https://github.com/rburkey2005/virtualagc/tree/master/Luminary099 and simply checked against scans at http://www.ibiblio.org/apollo/ScansForConversion/Luminary099/ to verify that they belong.

The only problem that I spotted was some sort of transcription error with Pages 299 and 300 in EXTENDED_VERBS.agc. I felt it was most important to add the files to the repository first, so that corrections will be in the git logs. I have not yet done any detailed examination for errors in these original virtualagc files. If you have problems seeing the files in the pull request because of the size, they are also in my upstream branch at https://github.com/proudindiv/Apollo-11/tree/upstream .

Gary Young
aka proudindiv

[wopian]

Yeah, looks like the people who digitalised that file mislabeled the last 2 pages: pages 300 and 301 instead of 299 and 300.

The real page 301 is this file: https://github.com/proudindiv/Apollo-11/blob/upstream/Luminary099/PINBALL_NOUN_TABLES.agc

On another note - woo 2x more work when I get round to checking the Luminary files 😆

[proudindiv]

Did you notice Comanche055.binsource and Luminary099.binsource in the rburkey2005/virtualagc repo? I'm thinking of running their assembler on the sources and comparing, or writing my own simple assembler. Do you think we should bring those files into chrislgarry/Apollo-11?

[wopian]

I would disagree with adding those files.

This repo is a historical archive of the Apollo 11 source code, VirtualAGC was made to compile the Apollo 11 code (and will be pulling the .agc files from here once they've all been checked)

Scroll down on #38

cc @chrislgarry

[proudindiv]

But with that argument, the historical Apollo 11 source code is defined by the jpg images linked to in the chrislgarry/master README.md file. The added 51 files from the VirtualAGC are required if you are going to match the images. They are also required if you are going to compile the source code and fly the Apollo-11 to the moon. There are issues with the encoding used in the VirtualAGC transcriptions representing the original source code, but adding the 51 files doesn't change that issue.

I'm sorry, I went back and re-read your comment, and realize that you were talking about the two .binsource files. Those files are a modern creation from the original sources, and as such can be excluded from the historical archive. They are better placed in a modern analysis of the historical code, and I agree with you on excluding them.

But with your argument, we need to remove the file "HeaderTemplate.agc" and discuss the "MAIN.agc" files and splitting the source lines (cards) into 174 files (plus two MAIN.agc files) instead of only 2 files representing the original card decks. See VirtualAGC's Programmer's Manual for what I am talking about.

Thanks for the link to #38, I hadn't seen that but had inferred the information in the discussion. I'm a long retired programmer and was programming on similar style programs in the later 1960's. I became interested in the Apollo-11 code when it was announced because it brings back lots of memories. Reading the code is very intimate because I can see what the original programmers were thinking. I started my Literate version of the code to give me a structure to reverse engineer in modern terms what was in it. We'll see how long I work with it and keep up the effort.

Gary Young
aka proudindiv

[chrislgarry]

@wopian yep that's my stance as well. @proudindiv yes I did plan on doing something with main.agc since its purpose is to be a wrapper to organize all of the assembly files for compliation, but it slipped my mind. We could simply just remove it if there is no original logic in there. I haven't looked yet. I also agree with splitting into the original number of files so we don't have multiple original assembly files in one digital assembly file here. And removal of header template if it's not original.