Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compile warning if player sprite sheet isn't set #462

Merged
merged 1 commit into from Aug 25, 2020

Conversation

pau-tomas
Copy link
Contributor

@pau-tomas pau-tomas commented Aug 23, 2020

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Add compile warning if player sprite sheet is set to None.

  • What is the current behavior? (You can also link to an open issue here)

Compile fails with TypeError: Cannot read property 'plugin' of undefined when no sprite sheet has been selected for the Player. See #447

  • What is the new behavior (if this is a feature change)?

A more clear Player Sprite Sheet isn't set. Please, make sure to select a Sprite Sheet in the Project editor. error is shown on compile.

image

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

  • Other information:

This doesn't solve the core issue of #447 (how did the player sprite sheet ended up being None?). But it should help users to fix the issue by themselves if they get there.

@chrismaltby chrismaltby merged commit 413c03a into chrismaltby:v2beta Aug 25, 2020
@chrismaltby
Copy link
Owner

Thanks @pau-tomas I can reproduce the error by just deleting the currently active player sprite sheet png file and building. This error is much better than the random plugin one that appears

@pau-tomas pau-tomas deleted the fix/447 branch December 25, 2021 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants