Allow Jekyll v4 while keeping the theme compatible with the GitHub Pages gem #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the dependency range for Jekyll such that the theme can be used with both the latest version of Jekyll (4.2), as well as the version compatible with the GitHub Pages gem (3.9).
The reason I am suggesting this change is that I want to use this theme for a new Jekyll site that I am not deploying using the GitHub Pages gem, and I would like to have that site start on a newer version of Jekyll since the sass dependency in Jekyll v3.9 is end of life, and in general I would much prefer starting a new project with latest versions for maintainability and access to new features, etc. Also, see the comment I left in issue #26.
Testing:
bundle install
) and then ran the hot reload server (bundle exec jekyll serve
). Jekyll version4.2.1
was installed and the site built and ran as I would expect.remote_theme
configuration to point it at this branch. Jekyll version 3.9 was used to build the site and it works as expected - can see the site here.Thank you for considering!