Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Jekyll v4 while keeping the theme compatible with the GitHub Pages gem #113

Merged
merged 2 commits into from Feb 17, 2022

Conversation

eheinrich
Copy link
Contributor

This PR updates the dependency range for Jekyll such that the theme can be used with both the latest version of Jekyll (4.2), as well as the version compatible with the GitHub Pages gem (3.9).

The reason I am suggesting this change is that I want to use this theme for a new Jekyll site that I am not deploying using the GitHub Pages gem, and I would like to have that site start on a newer version of Jekyll since the sass dependency in Jekyll v3.9 is end of life, and in general I would much prefer starting a new project with latest versions for maintainability and access to new features, etc. Also, see the comment I left in issue #26.

Testing:

  • To test that this theme works with Jekyll v4, I installed the project dependencies from my local checkout of this branch (bundle install) and then ran the hot reload server (bundle exec jekyll serve). Jekyll version 4.2.1 was installed and the site built and ran as I would expect.
  • To test that this branch still works with the GitHub Pages gem, I created a repository with a simple jekyll site and set the remote_theme configuration to point it at this branch. Jekyll version 3.9 was used to build the site and it works as expected - can see the site here.

Thank you for considering!

@chrisrhymes
Copy link
Owner

Thank you for this. I wasn't sure if it was possible.

@chrisrhymes chrisrhymes merged commit 8579413 into chrisrhymes:master Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants