Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Jekyll v4 while keeping the theme compatible with the GitHub Pages gem #113

Merged
merged 2 commits into from
Feb 17, 2022
Merged

Allow Jekyll v4 while keeping the theme compatible with the GitHub Pages gem #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e19d792
Update jekyll dependency version range to allow jekyll v4
eheinrich Feb 14, 2022
2cc6a12
Update README.md
eheinrich Feb 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ The theme uses [Alpine.js](https://github.com/alpinejs/alpine) for its interacti

## Installation

**This theme requires Jekyll 3.9 to be compatible with GitHub Pages.**

Add this line to your Jekyll site's `Gemfile`:

```ruby
Expand All @@ -57,7 +55,7 @@ And add this line to your Jekyll site's `_config.yml`:
theme: bulma-clean-theme
```

If you are deploying to GitHub pages, then you can also install the [GitHub Pages gem](https://github.com/github/pages-gem) and use `remote_theme` instead of `theme` in your `_config.yml`.
If you are deploying to GitHub pages, then you can also install the [GitHub Pages gem](https://github.com/github/pages-gem) and use `remote_theme` instead of `theme` in your `_config.yml`. **Note that the GitHub Pages gem requires Jekyll version 3.9.**

```yaml
# With GitHub Pages Gem
Expand Down
2 changes: 1 addition & 1 deletion bulma-clean-theme.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Gem::Specification.new do |spec|

spec.files = `git ls-files -z`.split("\x0").select { |f| f.match(%r!^(assets|_layouts|_includes|_sass|_posts|blog|LICENSE|README|package|node_modules|favicon)!i) }

spec.add_runtime_dependency "jekyll", "~> 3.9"
spec.add_runtime_dependency "jekyll", ">= 3.9", "< 4.3"
spec.add_runtime_dependency "jekyll-feed", "~> 0.15"
spec.add_runtime_dependency "jekyll-sitemap", "~> 1.4"
spec.add_runtime_dependency "jekyll-paginate", "~> 1.1"
Expand Down