Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive images. #27

Merged
merged 1 commit into from
Mar 10, 2018
Merged

Conversation

leventelist
Copy link
Contributor

Scale images.

@gillesdemey
Copy link
Contributor

This is badly needed for oversized images, can we merge this in?

@chrissimpkins
Copy link
Owner

Are you able to validate that this works as intended? I have not done this myself and don't have time at the moment to do so but would be happy to merge if you can provide this validation for it. If not, we can push to a branch where users can try it and provide feedback.

Let me know. thx

@gillesdemey
Copy link
Contributor

gillesdemey commented Mar 9, 2018

I’ve validated this on my local fork, though I used a slightly stricter p > img selector to make sure we don’t impact images outside of the content area.

@chrissimpkins
Copy link
Owner

Do you want to base those changes on this branch and PR in? We can merge commits from both of you.

@gillesdemey gillesdemey mentioned this pull request Mar 9, 2018
@gillesdemey
Copy link
Contributor

Rebased in #40

@chrissimpkins chrissimpkins merged commit 1940c40 into chrissimpkins:master Mar 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants