Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRE_SELECTED_PROVIDER and PROVIDER_HOST are messy #43

Closed
christian-hawk opened this issue Jan 5, 2023 · 0 comments · Fixed by #49 or #50
Closed

PRE_SELECTED_PROVIDER and PROVIDER_HOST are messy #43

christian-hawk opened this issue Jan 5, 2023 · 0 comments · Fixed by #49 or #50
Assignees
Labels
bug Something isn't working

Comments

@christian-hawk
Copy link
Owner

When PRE_SELECTED_PROVIDER = True, the PRE_SELECTED_PROVIDER_ID was sent as query param to auth endpoint.

In last PR merged, there were created a similar PROVIDER_HOST_STRING:

def get_provider_host():

PROVIDER_HOST_STRING misses boolean conditional, and is ALWAYS in the query param. This causes unexpected behaviour.

@christian-hawk christian-hawk added the bug Something isn't working label Jan 5, 2023
@christian-hawk christian-hawk self-assigned this Jan 5, 2023
christian-hawk added a commit that referenced this issue Jan 7, 2023
christian-hawk added a commit that referenced this issue Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant