Is use of hsc2hs necessary? #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christian-marie
pushed a commit
that referenced
this pull request
Dec 16, 2013
Is use of hsc2hs necessary?
|
You are correct! hsc2hs allows us to use it's preprocessor things like peek and sizeof to write haskell for attributes pulled out of headers and such. So far though, I've managed to get away with opaque references everywhere. Thus, never actually made use of it. If we've gotten this far without, I don't see us needing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strangest thing. I went to all the trouble to hack support for .hsc files into my build wrapper, then started looking at what the output from hsc2hs happened to be, and discovered it was essentially ... the same.
From which I realized that FFI works without requiring the hsc2hs preprocessor, at least it appears to. So for the hell of it I stripped out the use of hsc2hs and converted .hsc → .hs and gave
make testa go. Somewhat to my surprise, it built and checked.Makes for an annoying diff off the command line because of Git's pathologically useless approach to file renames; something GitHub presents better.
AfC