[pull] master from overhangio:master #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Contrary to what we might expect, `npm install` does not install pinned requirements from a project's package-lock.json. That's the responsibility of `npm ci`: https://docs.npmjs.com/cli/v8/commands/npm-ci Running `npm ci` is also *much* faster than `npm install`, so that's a huge win. See this issue for reference: openedx/wg-frontend#100
When running multiple concurrent versions of a plugin there are sometimes version conflicts that prevent the plugin from being loaded. Prior to v1, Tutor was correctly ignoring plugins that could not be loaded. During the transition to v1 we lost that feature because we only captured TutorErrors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )