Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove python-can >=v4.0.0 as dependency #318

Closed
wants to merge 1 commit into from

Conversation

VonSquiggles
Copy link

Bugs in python-can v4.0.0 break the API. Remove as dependency option until bugs are fixed.

@acolomb
Copy link
Collaborator

acolomb commented Dec 22, 2022

What bugs exactly are you talking about? What is it that breaks? Are these maybe fixed by now so we could upgrade the dependency to a known good version of python-can?

@VonSquiggles
Copy link
Author

I don't recall the specific issues I was having, but Python-can v4 has several API changes, and the latest release on this repo is based on v3 API. There are plenty of known good versions of python-can v3 that you can use (looks like 3.3.4 is latest)

@acolomb
Copy link
Collaborator

acolomb commented Dec 28, 2022

I guess you are talking about the issues mentioned in #296? If there are others, could you please test again to pinpoint them?

Disallowing python-can >= 4.0.0 as a dependency is not a good option for the majority of the user-base. Since we only require >= 3.0.0, you can pin the last working version from that branch easily for your use-case, until the underlying bug in python-can (hardbyte/python-can#1285) is fixed. Thus I'd lean toward closing this PR.

@zariiii9003
Copy link

zariiii9003 commented Jan 2, 2023

@VonSquiggles if you have problems with the Ixxat interface, a pull request in python-can would be helpful. The maintainers do not have access to the hardware.

Edit: It might have been fixed in hardbyte/python-can#1141

@fs570714
Copy link

fs570714 commented Jun 30, 2023

@zariiii9003, @VonSquiggles
I use the Ixxat Interface with the canopen 2.1.0 and the python-can version 4.2.2 where the only issue I observed, occurred when using the network.sync.start() function.

File "XXX", line 55, in <module>
network.sync.start(0.010)
File "XXX\Python\Python311\Lib\site-packages\canopen\sync.py", line 38, in start
self._task = self.network.send_periodic(self.cob_id, [], self.period)
File "XXX\Programs\Python\Python311\Lib\site-packages\canopen\network.py", line 233, in send_periodic
return PeriodicMessageTask(can_id, data, period, self.bus, remote)<br/><br/>
File "XXX\Python\Python311\Lib\site-packages\canopen\network.py", line 315, in __init__
self._start()
File "XXX\Python\Python311\Lib\site-packages\canopen\network.py", line 318, in _start
self._task = self.bus.send_periodic(self.msg, self.period)
File "XXX\python-can-develop\can\bus.py", line 245, in send_periodic
periodic_tasks = self._periodic_tasks

AttributeError: 'IXXATBus' object has no attribute '_periodic_tasks'

however this issue is solved with the pull request hardbyte/python-can#1532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants