Ixxat bus state and hardware errors detection #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1141 +/- ##
===========================================
- Coverage 65.28% 65.20% -0.08%
===========================================
Files 81 81
Lines 8832 8853 +21
===========================================
+ Hits 5766 5773 +7
- Misses 3066 3080 +14 |
|
#1119 created some conflicts |
|
@cowo78 I can do a review once they are resolved. |
Better handling of CAN error messages: - In case of HW errors (overrun, warning limit exceeded, bus coupling error) raise VCIError - In case of error log IXXAT-specific error codes
Use log.warning instead of deprecated log.warn.
…erty. Hardware error checking in _recv_internal() handles BUS OFF situation.
Merged
felixdivo
requested changes
Dec 18, 2021
…stent with BusABC
added 6 commits
December 20, 2021 08:44
…been loaded" This reverts commit ad11bf9.
felixdivo
approved these changes
Dec 22, 2021
|
Am I right in that this only adds |
Correct. As mentioned in #1119 I would suggest to postpone a refactoring / code deduplication do another PR. |
|
I'd like this to get a single other review before merging. |
|
@hardbyte? 😃 |
hardbyte
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented IXXATBus.state() property.
Hardware errors are detected in _recv_internal() and raise an exception.