Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-opr #125

Closed
jaredgalanis opened this issue Mar 18, 2018 · 1 comment
Closed

git-opr #125

jaredgalanis opened this issue Mar 18, 2018 · 1 comment

Comments

@jaredgalanis
Copy link

Hey Chris, I'm just about finished with your awesome Mastering Git series on Upcase. I've learned a lot so far and definitely will come back to watch it all a second time.

I noticed that the version of the git-opr file you reference in the Upcase notes for the remotes video has a reference to an older version of this file.

I found the most recent version and I tried using it for one of my company's projects, but I am getting a "Not found" error when curl'ing the github api. I'm assuming this has something to do with my level of ssh access to the git repo's at my org.

That being the case I opted for using your open_pull_request_for_repo_branch(repo, branch) method, but I think the repo/remote_url variable already includes //github.com and so the url that it attempts to open is broken. Just removing that gets it opening properly for me:

def open_pull_request_for_repo_branch(repo, branch)
  system("open https:#{repo}/pull/#{branch}")
end

Many thanks again for all of your hard work on the Upcase product and sharing this info as well!

@christoomey
Copy link
Owner

Hi @jaredgalanis thanks for the kind words! I'm really glad you found the videos valuable.

I've actually updated the script a bit more (I just pushed up those changes) and it no longer uses the offending method, so I think that's why I wasn't seeing this issue. You can check that out here: https://github.com/christoomey/dotfiles/blob/master/bin/git-opr.

I'm going to close this now as things are working fine for me, and hopefully you'll find the update to work for you (note it requires chrome-cli).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants