fix: fix checks pluralized event if only one fails

christophehurpeau · Nov 10, 2023 · 54d6e95 · 54d6e95
1 parent 28db2b2
commit 54d6e95
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/events/pr-handlers/actions/calcAndUpdateChecksAndStatuses.ts b/src/events/pr-handlers/actions/calcAndUpdateChecksAndStatuses.ts
@@ -70,15 +70,16 @@ async function checksAndStatusesSlackMessageAddOrUpdate<
           createOwnerPartOptions,
         );
 
-        const failedChecksAndStatusesString = [
+        const failedChecksAndStatuses = [
           ...failedOrWaitingChecksAndStatuses.failedChecks,
           ...failedOrWaitingChecksAndStatuses.failedStatuses,
-        ]
+        ];
+        const failedChecksAndStatusesString = failedChecksAndStatuses
           .map((failedCheckOrStatusName) => `\`${failedCheckOrStatusName}\``)
           .join(', ');
 
         return `:x: Check${
-          failedChecksAndStatusesString.length > 1 ? 's' : ''
+          failedChecksAndStatuses.length > 1 ? 's' : ''
         } ${failedChecksAndStatusesString} failed on ${prOwnership} ${prLink}`;
       };