Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with dplyr 1.1.0 #1

Merged
merged 6 commits into from
Dec 13, 2022

Conversation

lionel-
Copy link
Contributor

@lionel- lionel- commented Dec 12, 2022

This PR makes your package compatible with the next version of dplyr:

  • cur_data() and cur_data_all() are deprecated in favour of pick().
  • c_across() now requires an explicit selection
  • first(df) now selects the first row instead of the first column

Regarding pick() the very last commit renames it to across() which works equivalently to pick() when a mapping function is omitted. I did this so that your package is also compatible with the current version of dplyr. This way, you can send a pre-emptive release to CRAN, which would be appreciated. We plan to release on Jan 27. Then you can revert this commit once dplyr 1.1.0 is on CRAN.

utils.R is Rbuildignored
@christopherkenny christopherkenny merged commit 616ece0 into christopherkenny:master Dec 13, 2022
@christopherkenny
Copy link
Owner

Thanks @lionel- for the fix here. I appreciate it. I'll get this submitted to CRAN in the next day or so, once I've confirmed no changes with winbuilder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants