Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acceptable for variables? #72

Closed
ScottTheHippy opened this issue May 16, 2022 · 3 comments · Fixed by #73
Closed

Acceptable for variables? #72

ScottTheHippy opened this issue May 16, 2022 · 3 comments · Fixed by #73

Comments

@ScottTheHippy
Copy link

Howdy- I'm trying to get the screen to show the time 24/7. What I'm finding is that the variable(s) operatingHours, screenBlankHours, and/or outOfHoursName seem to be in effect even if deleted. I tried setting screenBlankHours to "0" and that didn't seem to make a difference. Is there some combination of these variable settings that will lead to the clock showing 24/7? Thanks, and fun thing to build. I had the same screen as you, and I might have used a lot of bad language moving that resistor. :)

@ScottTheHippy
Copy link
Author

As a follow up, it seems the big hurdle is screenBlankHours. If I delete the variable, it operates on the 1-6 default. What disables this all together? I'll try adding it back and setting it to 0-0.

chrisys added a commit that referenced this issue May 17, 2022
Change-type: patch
Signed-off-by: Chris Crocker-White <chriscw@balena.io>
chrisys added a commit that referenced this issue May 17, 2022
Change-type: patch
Signed-off-by: Chris Crocker-White <chriscw@balena.io>
chrisys added a commit that referenced this issue May 17, 2022
Change-type: patch
Signed-off-by: Chris Crocker-White <chriscw@balena.io>
@chrisys
Copy link
Owner

chrisys commented May 17, 2022

@ScottTheHippy I've just written a fix for it to allow you to run with blank variables, when #73 merges give it a try and let me know!

chrisys added a commit that referenced this issue May 17, 2022
Default to all-day operation fixes #72
@chrisys
Copy link
Owner

chrisys commented May 17, 2022

P.S. thanks for building the project and thanks for reporting this! I am glad you had fun :) Feel free to reopen this issue if this does not fix it.

@chrisys chrisys linked a pull request May 18, 2022 that will close this issue
cr3ative pushed a commit to CalamityJames/train-departure-display that referenced this issue Jun 29, 2023
Change-type: patch
Signed-off-by: Chris Crocker-White <chriscw@balena.io>
cr3ative pushed a commit to CalamityJames/train-departure-display that referenced this issue Jun 29, 2023
Default to all-day operation fixes chrisys#72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants