Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatible with upcoming RustSAT 0.5.0 #1

Closed
wants to merge 1 commit into from

Conversation

nfbruns
Copy link

@nfbruns nfbruns commented Apr 10, 2024

Added anyhow and thiserror packages to handle the errors in the new format.

@chrjabs chrjabs changed the title Compatible with rustsat 0.2.4 Compatible with upcoming RustSAT 0.5.0 Apr 11, 2024
@chrjabs
Copy link
Owner

chrjabs commented Apr 11, 2024

I won't be merging this until the next release of RustSAT is actually ready. And even then, I would like to properly use anyhow error in scuttle as well, rather than storing anyhow errors in an error enum, which somewhat defeats the purpose of anyhow. If you need scuttle to compile as is, the easiest is to check out the RustSAT repo at the rustsat-v0.4.3 tag. Once I deem the next version of RustSAT ready to be released (which means at least rustsat/#80, rustsat/#82 are merged, potentially also a fix for rustsat/#79), I'll properly bump the version of RustSAT and then make scuttle compatible as well.
I bump version numbers only right before release since RustSAT will be automatically published by CI once the version number if bumped, so the main branch of RustSAT at the moment is not 0.4.3 but the upcoming release 0.5.0.

@nfbruns
Copy link
Author

nfbruns commented Apr 20, 2024

That makes sense. Then I will wait for the proper fix and use this branch for myself as a temporary solution to get it running with the most recent main branch! Thank you for the explanation.
I will close the PR since it is not needed any more now.

@nfbruns nfbruns closed this Apr 20, 2024
@chrjabs
Copy link
Owner

chrjabs commented May 16, 2024

To give a brief update on my progress on this, on the develop branch I now have a version of scuttle that is compatible with RustSAT 0.5.0 and got some major restructuring of the project layout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants