-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Factor out C-API, Python API and solver tests into their own crates #80
Conversation
This is just some uninformed advice, based on hitting a similar issue (you can see people talking about it here: rust-lang/cargo#6313 ) Basically, I think, cdylibs don't work well with packages that get built multiple times, and rustsat is now built with different features in different places. The best (again, I think) solution would be to pull the C and Python interface out into their own little package, which requires You could try removing |
Thanks for the pointers, that might come in very handy. So far I wanted to keep the Python API in the main crate so that it can follow the main versioning more easily, but this might have to change then. |
Looks like the |
0c0177a
to
fb625b9
Compare
To-dos before merging:
|
factor out C-API into separate crate and tooling around that
288c6c6
to
205077e
Compare
More To-dos:
|
factor out Python API into separate crate and tooling around that
- include minisat and glucose as submodules - specify linked libraries in code rather than in the build script
1bbbf5e
to
62c30c1
Compare
Something about dependency resolution makes this break on macos and windows but not on Linux.