-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Cohere v7 SDK support #1445
Labels
Comments
1 task
tazarov
added a commit
to amikos-tech/chroma-core
that referenced
this issue
Dec 5, 2023
tazarov
added a commit
to amikos-tech/chroma-core
that referenced
this issue
Dec 5, 2023
- Fixed an issue with v5/v6 init Refs: chroma-core#1445
jeffchuber
pushed a commit
that referenced
this issue
Dec 19, 2023
#1445 ## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - Support for cohere-ai SDK 7+ ## Test plan *How are these changes tested?* - [x] Tests pass locally with `yarn test` ## Documentation Changes *Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs repository](https://github.com/chroma-core/docs)?*
Closed by #1460 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the problem
Chroma's Cohere peer dependency is locked to
5 || 6
. Therefore, if another package (LangChain.js specifically) has a peer dep on Chroma, it is restricted to Cohere version5 || 6
as well, even if both packages are not being used at the same time, otherwise it will break npm's default peer dependency resolution and make installs fail.https://github.com/chroma-core/chroma/blob/main/clients/js/package.json#L79
yarn
andpnpm
work, butnpm
has a very restrictive default for this:https://stackoverflow.com/questions/67185714/how-do-i-read-npm-conflicting-peer-dependency-error-messages
Describe the proposed solution
Add support for Cohere's new major SDK version.
Alternatives considered
No response
Importance
i cannot use Chroma without it
Additional Information
No response
The text was updated successfully, but these errors were encountered: