Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH]: Added cohere-ai 7.0.0 support in package.json #1460

Merged

Conversation

tazarov
Copy link
Contributor

@tazarov tazarov commented Dec 4, 2023

#1445

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Support for cohere-ai SDK 7+

Test plan

How are these changes tested?

  • Tests pass locally with yarn test

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

Copy link

github-actions bot commented Dec 4, 2023

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readbility, Modularity, Intuitiveness)

@tazarov
Copy link
Contributor Author

tazarov commented Dec 4, 2023

@jeffchuber, I am working on the fix to the Cohere EF.

As @jacoblee93 suggested current version of the EF + Cohere SDK 7+ yields:

 CohereAiApi.init(this.api_key);
                  ^

TypeError: CohereAiApi.init is not a function

@tazarov
Copy link
Contributor Author

tazarov commented Dec 4, 2023

@jacoblee93, I'll have the fix later today

@jacoblee93
Copy link
Contributor

Awesome!!!

@tazarov
Copy link
Contributor Author

tazarov commented Dec 5, 2023

@jacoblee93, I think this is mostly done. Tested with all, v5, v6 and v7 SDKs and appears to be working. Can you also check on your end?

@tazarov
Copy link
Contributor Author

tazarov commented Dec 5, 2023

@jeffchuber, have a look, too, if something jumps out.

@tazarov tazarov marked this pull request as ready for review December 6, 2023 06:23
@tazarov tazarov changed the title [WIP][ENH]: Added cohere-ai 7.0.0 support in package.json [ENH]: Added cohere-ai 7.0.0 support in package.json Dec 7, 2023
@jacoblee93
Copy link
Contributor

@jeffchuber can we get this merged?

Copy link
Contributor

@jeffchuber jeffchuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @tazarov !

@jeffchuber jeffchuber merged commit 2366196 into chroma-core:main Dec 19, 2023
95 checks passed
@jeffchuber
Copy link
Contributor

@jacoblee93 released in 1.7.3 https://www.npmjs.com/package/chromadb

@jacoblee93
Copy link
Contributor

Awesome CC @bracesproul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants