-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH]: Added cohere-ai 7.0.0 support in package.json #1460
[ENH]: Added cohere-ai 7.0.0 support in package.json #1460
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
@jeffchuber, I am working on the fix to the Cohere EF. As @jacoblee93 suggested current version of the EF + Cohere SDK 7+ yields: CohereAiApi.init(this.api_key);
^
TypeError: CohereAiApi.init is not a function |
@jacoblee93, I'll have the fix later today |
Awesome!!! |
- Fixed an issue with v5/v6 init Refs: chroma-core#1445
@jacoblee93, I think this is mostly done. Tested with all, v5, v6 and v7 SDKs and appears to be working. Can you also check on your end? |
@jeffchuber, have a look, too, if something jumps out. |
@jeffchuber can we get this merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you @tazarov !
@jacoblee93 released in |
Awesome CC @bracesproul |
#1445
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
yarn test
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?