[Bug]: Inconsistent upsert/update API responses

[tazarov]

What happened?

In client/server mode, the API does not return a proper response for update and upsert collection ops when there is a mismatch in embedding and collection dimensions.

Versions

Chroma 0.4.18, Python 3.11

Relevant log output

Response for add:

Exception: {"detail":"Embedding dimension 384 does not match collection dimensionality 1536"}

Response for update and upsert:

HTTPError: 400 Client Error: Bad Request for url: http://localhost:8000/api/v1/collections/1cc231ef-b34b-463a-9fc7-69b3184ba2a6/update

[tazarov]

To reproduce:

https://gist.github.com/tazarov/35539b3a52bd02814edc0b565ec227eb

[shardulkulkarni95]

Can you assign this to me?

[HammadB]

Of course! Thanks.

[shardulkulkarni95]

raised PR. #1470

Please review.

[ChrisLahaye]

Also noticed that the upsert endpoint returns null since chroma >=0.4.16 instead of true/false. Will #1470 also fix this?

[tazarov]

@ChrisLahaye, I don't think it will. The change you are referring to was introduced way way back in May-23 - https://github.com/chroma-core/chroma/pull/524/files#diff-1782a536c97875ef5659801ed08b6157216affe33150a87e6adbae02844fc56bL209

Returning None is still the desired behaviour until we switch the response scheme.

[ChrisLahaye]

@tazarov Thank you for that information! Great to know that it is the intended behavior and not a bug. The chromadb JavaScript package still uses a promise boolean as return type for the upsert function though.

[tazarov]

Fix for this implemented. Closing