[BUG] - corrected error response for update and upsert #1466

[shardulkulkarni95]

Description of changes

Summarize the changes made by this PR.

• Improvements & Bug fixes
  • Error response was containing status code and stack massage altered to chroma error to make uniform response to user. followed same logic as add.

Test plan

How are these changes tested?

To reproduce:

https://gist.github.com/tazarov/35539b3a52bd02814edc0b565ec227eb

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

[github-actions]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readbility, Modularity, Intuitiveness)

[shardulkulkarni95]

closes #1466

[tazarov]

@shardulkulkarni95, this looks good. I've tested it, but I'd like you also to add a test to verify this functionality is as expected across add, modify and upsert when trying to insert different dimensions - your tests should land here - https://github.com/chroma-core/chroma/blob/main/chromadb/test/test_api.py

[shardulkulkarni95]

hey @tazarov, added tests for update and upsert. seems test for add already added in test_api.py (line no. 731)

also attached screenshot for passed tests update and upsert.

please review. #1466

[tazarov]

@shardulkulkarni95, this looks good. Thank you.

[shardulkulkarni95]

welcome @tazarov

[HammadB]

Thank you!