-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] - corrected error response for update and upsert #1466 #1470
[BUG] - corrected error response for update and upsert #1466 #1470
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
closes #1466 |
@shardulkulkarni95, this looks good. I've tested it, but I'd like you also to add a test to verify this functionality is as expected across |
@shardulkulkarni95, this looks good. Thank you. |
welcome @tazarov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
To reproduce:
https://gist.github.com/tazarov/35539b3a52bd02814edc0b565ec227eb
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?