Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Adds memberlist manager #1354

Merged
merged 10 commits into from
Nov 16, 2023
Merged

[ENH] Adds memberlist manager #1354

merged 10 commits into from
Nov 16, 2023

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Nov 8, 2023

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Adds a memberlist manager to coordinator that listens to pod updates and reconciles them against a CR
  • New functionality
    • N/A

Test plan

How are these changes tested?
New unit tests were added for this case for each module

  • Tests pass locally with pytest for python, yarn test for js

Documentation Changes

None

bin/cluster-test.sh Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Nov 8, 2023

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readbility, Modularity, Intuitiveness)

@HammadB HammadB force-pushed the hammad/add_memberlist_manager branch from 170f939 to e5e4ce0 Compare November 8, 2023 19:48
Copy link
Contributor

@tazarov tazarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major comments. Am I correct in my understanding that this is just an initial scaffolding for the controller, which will later take care of managing workers?

This was referenced Nov 10, 2023

func (s *CRMemberlistStore) GetMemberlist() (*Memberlist, error) {
gvr := getGvr()
unstrucuted, err := s.dynamicClient.Resource(gvr).Namespace("chroma").Get(context.TODO(), "worker-memberlist", metav1.GetOptions{}) //.Namespace(m.coordinator_namespace).Get(context.TODO(), m.memberlist_custom_resource, metav1.GetOptions{})
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: investigate how to use context properly (pass into struct?)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@Ishiihara Ishiihara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending addressing review comments.

We need to followup on:

  • Batch event processing to smooth start up and transient failures.
  • Evaluate whether we need to customized CRD clients. We may need more CRDs to handle topic reconfiguration, ddl and TSOs.

@HammadB HammadB force-pushed the hammad/add_memberlist_manager branch from 9660a1e to ed94908 Compare November 16, 2023 22:05
@HammadB HammadB merged commit e0860cd into main Nov 16, 2023
95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants