Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Proxy assignment #1378

Merged
merged 2 commits into from
Nov 17, 2023
Merged

[ENH] Proxy assignment #1378

merged 2 commits into from
Nov 17, 2023

Conversation

HammadB
Copy link
Collaborator

@HammadB HammadB commented Nov 10, 2023 •
edited

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Makes proxies route to the correct worker
  • New functionality
    • ...

This was referenced Nov 10, 2023
Merged
Merged
Merged
Merged
@HammadB Graphite App
Copy link
Collaborator Author

HammadB commented Nov 10, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readbility, Modularity, Intuitiveness)

@HammadB HammadB marked this pull request as ready for review November 16, 2023 00:35
@zhangjinpeng87 zhangjinpeng87 mentioned this pull request Nov 16, 2023
Open
1 task
Ishiihara
Ishiihara approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@Ishiihara Ishiihara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HammadB HammadB force-pushed the hammad/worker_topic_assignment branch 2 times, most recently from 7e9bd2b to e48fb75 Compare November 16, 2023 23:58
@HammadB HammadB force-pushed the hammad/proxy_worker_assignment branch 4 times, most recently from 4df1b15 to 79a236f Compare November 17, 2023 00:34
@HammadB HammadB force-pushed the hammad/worker_topic_assignment branch from ac503fa to 444988a Compare November 17, 2023 00:39
@HammadB HammadB force-pushed the hammad/proxy_worker_assignment branch 2 times, most recently from 7acb711 to d6334e0 Compare November 17, 2023 00:55
@HammadB HammadB force-pushed the hammad/proxy_worker_assignment branch from d6334e0 to 4ddf644 Compare November 17, 2023 02:28
@HammadB HammadB changed the base branch from hammad/worker_topic_assignment to main November 17, 2023 02:28
@HammadB HammadB enabled auto-merge (squash) November 17, 2023 02:28
@HammadB HammadB merged commit c9b9521 into main Nov 17, 2023
184 of 189 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ishiihara Ishiihara Ishiihara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HammadB @Ishiihara