[ENH]: Improve tenant and DB validation handling #1494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
HammadB
reviewed
Dec 11, 2023
chromadb/api/client.py
Outdated
| ) | ||
| if ex.response.status_code == 404: | ||
| raise ValueError( | ||
| f"It appears your Chroma server is running an older version of Chroma {self.get_version()}. " |
There was a problem hiding this comment.
This error message could be a bit confusing, its only printing the client version right?
There was a problem hiding this comment.
Oh I see, its saying the validation routes don't exist, maybe we can make that clearer?
There was a problem hiding this comment.
Now it looks like this:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/tazarov/experiments/chroma-experiments/oss/1480-better-tenant-db-validation/chromadb/__init__.py", line 182, in HttpClient
return ClientCreator(tenant=tenant, database=database, settings=settings)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/tazarov/experiments/chroma-experiments/oss/1480-better-tenant-db-validation/chromadb/api/client.py", line 148, in __init__
self._validate_tenant_database(tenant=tenant, database=database)
File "/Users/tazarov/experiments/chroma-experiments/oss/1480-better-tenant-db-validation/chromadb/api/client.py", line 444, in _validate_tenant_database
raise ValueError(
ValueError: It appears you are using newer version of Chroma client (v0.4.18) that is not compatible with Chroma server (v0.4.12). Please upgrade your server to the latest version.
tazarov
commented
Dec 12, 2023
| try: | ||
| resp.raise_for_status() | ||
| except requests.HTTPError: | ||
| raise (Exception(resp.text)) |
There was a problem hiding this comment.
Removed wrapping specific error (HTTP) into a generic Exception wrapper.
- Fixed an issue with generic JSON errors - they need to match Chroma format with Error type and error message - Cleaned up collection add unnecessary try/except - Fixed unit mock tests to pass Refs: chroma-core#1480
TODO - regen of the API is needed for error message. Refs: chroma-core#1480
- Exported Settings in __all__ Refs: chroma-core#1480
Open
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #1480
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytestfor pythonDocumentation Changes
N/A