Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Fix integration test #1570

Merged
merged 1 commit into from
Dec 22, 2023
Merged

[BUG] Fix integration test #1570

merged 1 commit into from
Dec 22, 2023

Conversation

Ishiihara
Copy link
Contributor

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • This fixes integration test caused by topic assignment algorithm change
  • New functionality
    • ...

Test plan

How are these changes tested?

  • Manual integration test.
  • CI pass

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

@github-actions GitHub Actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readbility, Modularity, Intuitiveness)

@Ishiihara Ishiihara requested review from levand, HammadB and beggers and removed request for levand December 22, 2023 20:09
beggers
beggers approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@beggers beggers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All checks passed!! Thank you liquan!

@Ishiihara Ishiihara merged commit 4ff8adf into chroma-core:main Dec 22, 2023
97 checks passed
@rancomp
Copy link
Contributor

rancomp commented Jan 3, 2024

Was it necessary to change the test? It looks like it fails now, see:
https://github.com/chroma-core/chroma/actions/runs/7350932128/job/20101500482
https://github.com/chroma-core/chroma/actions/runs/7315222780/job/20135918641?pr=1580

@rancomp rancomp mentioned this pull request Jan 3, 2024
Closed
@beggers
Copy link
Member

beggers commented Jan 3, 2024

It was! It was failing with much higher frequency before we checked in this PR. However I saw the flakiness in your PR which you linked and just checked in #1608 which should de-flake this test for good.

@rancomp
Copy link
Contributor

rancomp commented Jan 3, 2024

Ohhh alright I see! Thanks @beggers , I was a bit hasty and didn't notice your PR :)

@beggers
Copy link
Member

beggers commented Jan 3, 2024

No worries! I greatly appreciate the involvement :) If you merge main into your PR the tests should pass.

@Ishiihara Ishiihara deleted the fix_test_system branch March 7, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beggers beggers beggers approved these changes

@HammadB HammadB Awaiting requested review from HammadB

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ishiihara @rancomp @beggers