Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sysdb test flakiness #1608

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Fix sysdb test flakiness #1608

merged 1 commit into from
Jan 3, 2024

Conversation

beggers
Copy link
Member

@beggers beggers commented Jan 3, 2024 •
edited

We need to sort by segment ID not type, since two of these have the same type and may be returned in either order by sysdb.

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Fix sysdb test flakiness by sorting by ID instead of type

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

@beggers
Fix sysdb test flakiness
2bcafeb 
We need to sort by segment ID not type, since two of these have the same type and may be returned in either order by sysdb.
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@Ishiihara Ishiihara self-requested a review January 3, 2024 19:40
Ishiihara
Ishiihara approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@Ishiihara Ishiihara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beggers beggers merged commit da116fa into main Jan 3, 2024
99 checks passed
@beggers beggers mentioned this pull request Jan 3, 2024
Merged
2 tasks
thorwhalen pushed a commit to thorwhalen/chroma that referenced this pull request Jan 11, 2024
@beggers @thorwhalen
Fix sysdb test flakiness (chroma-core#1608)
7a77097 
We need to sort by segment ID not type, since two of these have the same
type and may be returned in either order by sysdb.

## Description of changes

*Summarize the changes made by this PR.*
 - Improvements & Bug fixes
	 - Fix sysdb test flakiness by sorting by ID instead of type
	
## Test plan
*How are these changes tested?*

- [x] Tests pass locally with `pytest` for python, `yarn test` for js

## Documentation Changes
*Are all docstrings for user-facing APIs updated if required? Do we need
to make documentation changes in the [docs
repository](https://github.com/chroma-core/docs)?*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ishiihara Ishiihara Ishiihara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@beggers @Ishiihara