[BUG] Fix hosted chroma release trigger #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
HammadB
approved these changes
Jan 16, 2024
## Description of changes - Update openai call to use the new api (#1640 )
## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - This aligns the coordinator, rust worker, and python client on default/default as the pulsar tenant/namespace
## Description of changes - Docker gracefully shutdown (#1646 )
…ezvous hash of topics (#1651) ## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - Move cluster tests to a bigger machine. I suspect the default machines are too slow resulting in a time out. - Fix the coordinator sysdb tests to use rendezvous hashing since we cannot parametrize the service during integration tests easily.
## Description of changes
*Summarize the changes made by this PR.*
- Improvements & Bug fixes
- Update bin/cluster-test to build rust worker
- Parameterize dockerfile to support building the docker image for and
not for integration tests
- Add build.rs step for integration tests
- Make memberlist and storage tests only run in response to this flag
- New functionality
- Adds a basic storage system that gets/puts to s3
## Test plan
*How are these changes tested?*
New tests were added for basic use of storage.
- [x] Tests pass locally with `cargo test`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
Test plan
How are these changes tested?
pytestfor python,yarn testfor jsDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?