Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BLD]: JS client 1.9.1-alpha release #2150

Merged
merged 5 commits into from
Jun 13, 2024
Merged

[BLD]: JS client 1.9.1-alpha release #2150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
da07a30
feat: 1.9.1-alpha release
tazarov May 7, 2024
95f6d47
fix: Adjusting port to 8000 for the JS release workflow
tazarov May 7, 2024
4358f78
feat: Expanding isOffline error to include ENOTFOUND (DNS lookup fail…
tazarov May 7, 2024
0f4ec2d
fix: Fixing test docker compose and Chroma Fetch error for Node 16
tazarov May 7, 2024
8e382db
chore: Fixed a linting error
tazarov May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion clients/js/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "chromadb",
"version": "1.8.1",
"version": "1.9.1",
"description": "A JavaScript interface for chroma",
"keywords": [],
"author": "",
Expand Down
5 changes: 3 additions & 2 deletions clients/js/src/ChromaFetch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,10 @@ import { FetchAPI } from "./generated";

function isOfflineError(error: any): boolean {
return Boolean(
error?.name === "TypeError" &&
(error?.name === "TypeError" || error?.name === "FetchError") &&
(error.message?.includes("fetch failed") ||
error.message?.includes("Failed to fetch")),
error.message?.includes("Failed to fetch") ||
error.message?.includes("ENOTFOUND")),
);
}

Expand Down
6 changes: 5 additions & 1 deletion docker-compose.test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,8 @@ services:
- ALLOW_RESET=True
- IS_PERSISTENT=True
ports:
- 8000:8000
- "${CHROMA_PORT:-8000}:8000"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codetheweb I python tests don't like the default here. Lemme check.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually it's the test_net.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it was resolved?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird failure in linting. Reran, it's all fine now.


volumes:
chroma-data:
driver: local
Loading