[BLD]: JS client 1.9.1-alpha release #2150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
tazarov
force-pushed
the
release/js-1.9.1-alpha
branch
from
5b0252b
to
0e8f75a
Compare
|
Hi Trayan, I'm OOO most this week but I should be able to take a look Friday. |
codetheweb
approved these changes
Jun 12, 2024
tazarov
commented
Jun 12, 2024
| @@ -12,4 +12,10 @@ services: | |||
| - ALLOW_RESET=True | |||
| - IS_PERSISTENT=True | |||
| ports: | |||
| - 8000:8000 | |||
| - "${CHROMA_PORT:-8000}:8000" | |||
There was a problem hiding this comment.
@codetheweb I python tests don't like the default here. Lemme check.
There was a problem hiding this comment.
actually it's the test_net.
There was a problem hiding this comment.
looks like it was resolved?
There was a problem hiding this comment.
weird failure in linting. Reran, it's all fine now.
tazarov
force-pushed
the
release/js-1.9.1-alpha
branch
from
574dcfa
to
0e8f75a
Compare
tazarov
force-pushed
the
release/js-1.9.1-alpha
branch
from
0e8f75a
to
8e382db
Compare
Anush008
pushed a commit
to Anush008/chroma
that referenced
this pull request
Jun 27, 2024
## Description of changes *Summarize the changes made by this PR.* - Improvements & Bug fixes - JS version bump to `1.9.1` - Made the error handling more robust for offline errors (works with older Nodejs 16) - Fixed an issue with test docker-compose file where the port was not being correctly mapped, thus making the release WF tests fail ## Test plan *How are these changes tested?* - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Summarize the changes made by this PR.
1.9.1Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
N/A