[ENH] simplify logic for when to persist index changes #2539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
codetheweb
commented
Jul 18, 2024
| # Fields were added after the initial implementation | ||
| self.total_elements_updated = 0 | ||
| self.total_invalid_operations = 0 | ||
| self.__dict__.update(state) |
There was a problem hiding this comment.
I tested with pickle and it seems to be fine if you remove a field from a class def
HammadB
approved these changes
Jul 19, 2024
HammadB
reviewed
Jul 19, 2024
| @@ -132,9 +119,6 @@ def __init__(self, system: System, segment: Segment): | |||
| else: | |||
| self._persist_data = PersistentData( | |||
| self._dimensionality, | |||
| self._total_elements_added, | |||
There was a problem hiding this comment.
confirming this was not used anywhere else
There was a problem hiding this comment.
turns out this was the issue, I should have fully reasoned through it :/
self._total_elements_added isn't used in local_persistent_hnsw, but it is used in local_hnsw (the super class) and there's some non-obvious contracts between the two
codetheweb
added a commit
that referenced
this pull request
Jul 19, 2024
This reverts commit e93bacf.
codetheweb
added a commit
that referenced
this pull request
Jul 19, 2024
This reverts commit afe8947.
This was referenced Jul 19, 2024
codetheweb
added a commit
that referenced
this pull request
Jul 22, 2024
This reverts commit e93bacf.
codetheweb
added a commit
that referenced
this pull request
Jul 22, 2024
This reverts commit afe8947.
codetheweb
added a commit
that referenced
this pull request
Jul 23, 2024
This reverts commit e93bacf.
codetheweb
added a commit
that referenced
this pull request
Jul 23, 2024
This reverts commit afe8947.
codetheweb
added a commit
that referenced
this pull request
Jul 24, 2024
This reverts commit e93bacf.
codetheweb
added a commit
that referenced
this pull request
Jul 24, 2024
This reverts commit afe8947.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@HammadB and I discussed this. Makes it much easier to model the WAL behavior in tests while also simplifying the logic.