[ENH] simplify logic for when to persist index changes (re-apply with fix)

[codetheweb]

History:

• [ENH] simplify logic for when to persist index changes #2539 originally introduced some of the changes here
• it introduced a bug not caught by our test suite due to limitations of our suite at the time
• changes were reverted with Revert "[ENH] simplify logic for when to persist index changes" #2544
• and now this PR adds a test that was previously re-producing the bug before it was fixed here

Should not be merged until hnswlib version is bumped (bug around persisting a single item was recently fixed).

[github-actions]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

[codetheweb]

might be a better name for this

[codetheweb]

makes it slightly easier to copy/paste failing state machine repro

[codetheweb]

• [ENH] add vacuum CLI command #2519
• [ENH] automatically clean WAL #2557
• [ENH] add .clean_log() to Producers #2549
• [ENH] simplify logic for when to persist index changes (re-apply with fix) #2545 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @codetheweb and the rest of your teammates on Graphite