Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build progress reporting broken on second build #252

Closed
ghengeveld opened this issue Mar 22, 2024 · 2 comments · Fixed by #284
Closed

Build progress reporting broken on second build #252

ghengeveld opened this issue Mar 22, 2024 · 2 comments · Fixed by #284
Assignees
@ghengeveld
Labels
bug Classification: Something isn't working sev:S2
Milestone
include in sb upg...

Comments

@ghengeveld
Copy link
Member

ghengeveld commented Mar 22, 2024 •
edited
Loading

From AP-4387

How is the user affected? And what is the expected behavior?

image (3)

I expected to see this:

Running first test - Visual Tests addon for Storybook (Figma)

Is this something new users are seeing? If so, I would make the priority high.

How many and/or what class of users does this impact?

Potentially all new users during onboarding.

Is there a workaround?

Switch tabs after tests are complete.

What are the steps for reproducing the issue?

Here's a video of what I did.

Screenshare.-.2024-03-18.11_27_36.AM.mp4
@ghengeveld ghengeveld added bug Classification: Something isn't working sev:S3 labels Mar 22, 2024
@shilman shilman added this to the include in sb upgrade milestone Mar 28, 2024
@shilman shilman mentioned this issue Mar 28, 2024
Closed
@ghengeveld ghengeveld self-assigned this Mar 28, 2024
@ghengeveld
Copy link
Member Author

ghengeveld commented Apr 4, 2024 •
edited
Loading

Edit: nevermind, I was able to reproduce it.

@ghengeveld ghengeveld changed the title After make a change step, onboarding showing wrong screen instead of progress Build progress reporting broken on second build Apr 4, 2024
@ghengeveld ghengeveld mentioned this issue Apr 4, 2024
Merged
@ghengeveld
Copy link
Member Author

ghengeveld commented Apr 4, 2024 •
edited
Loading

Found the culprit 👍
#284

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghengeveld ghengeveld

Labels
bug Classification: Something isn't working sev:S2
Projects
None yet
Milestone
include in sb upgrade
Development

Successfully merging a pull request may close this issue.

Deeply reset the build progress when starting a new build chromaui/addon-visual-tests
3 participants
@ghengeveld @shilman @MichaelArestad