Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "No access" screen #134

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Oct 20, 2023

📦 Published PR as canary version: 0.0.108--canary.134.0415f58.0

✨ Test out this PR locally via:

npm install @chromaui/addon-visual-tests@0.0.108--canary.134.0415f58.0
# or 
yarn add @chromaui/addon-visual-tests@0.0.108--canary.134.0415f58.0

@linear
Copy link

linear bot commented Oct 20, 2023

AP-3279 Error screen when the user cannot access the project linked to the SB

Scenario:

  1. User 1 links SB repo to project Chromatic that they have access to.
  2. User 2 does not have access to that project
  3. User 2 opens the storybook + VT addon — what should they see?

Copy link
Member

@thafryer thafryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

src/screens/VisualTests/NoBuild.tsx Show resolved Hide resolved
@ghengeveld ghengeveld merged commit f8b610b into main Oct 20, 2023
6 checks passed
@ghengeveld ghengeveld deleted the ghengeveld/ap-3279-error-screen-when-the-user-cannot-access-the-project-linked branch October 20, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants