Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear all notifications when starting guided tour #200

Conversation

ghengeveld
Copy link
Member

This clears all notifications when the guided tour starts, so that there won't be a notification on top of the "𝑥 Changes" button.

Copy link
Member

@thafryer thafryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This one is tough to crystalize in tests. 😅

@ghengeveld ghengeveld merged commit d2c121e into main Mar 7, 2024
3 checks passed
@ghengeveld ghengeveld deleted the ghengeveld/ap-4079-bug-sometimes-notifications-can-appear-below-the-react branch March 7, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants