Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate running/latest build from viewed stories #69

Merged
merged 22 commits into from
Sep 4, 2023

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Sep 1, 2023

Implement behaviour for "next" builds discussed in linear, namely:

  1. Don't switch the story we are looking until you click a button in the eyebrow
  2. But if you change story, switch to a "next" latest build as soon as it is available.
  3. Additionally, always use the next build to drive the sidebar.

Relies on chromaui/chromatic-cli#810 and telescoping on #68

📦 Published PR as canary version: 0.0.51--canary.69.503ff0c.0

✨ Test out this PR locally via:

npm install @chromaui/addon-visual-tests@0.0.51--canary.69.503ff0c.0
# or 
yarn add @chromaui/addon-visual-tests@0.0.51--canary.69.503ff0c.0

@linear
Copy link

linear bot commented Sep 1, 2023

AP-3544 Implement "build of out date" behaviour

As discussed in Slack: https://chromaticqa.slack.com/archives/C051TQR6QLC/p1692354384352659

  1. When a new (local) build is running, show a eyebrow UI for the progress (AP-3559)
  2. When it is complete, continue to show the old build, but prompt the user to switch
  3. When they switch or change stories, show the new build from now on.
  4. When you change branch/commit, if there is a newer CI build available, behaviour similarly as to 2&3
  5. Alert users when there is a new build available on a newer commit on the current branch.

Some details still being thrashed out. The details of the eyebrow and 5. are probably large enough to deserve their own tickets.

Discussion here: https://www.notion.so/chromatic-ui/Persisting-information-in-the-addon-20f4b982692b40d09e4211635581e62b?pvs=4

Copy link
Member

@ghengeveld ghengeveld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're going to refactor this a bit more later on (mostly to pull apart VisualTests.tsx), but this is a step in the right direction 👍

src/Panel.tsx Show resolved Hide resolved
src/screens/VisualTests/VisualTests.tsx Outdated Show resolved Hide resolved
src/screens/VisualTests/VisualTests.tsx Outdated Show resolved Hide resolved
They are a bit messed up, but will revisit soon.
@tmeasday tmeasday marked this pull request as ready for review September 4, 2023 11:23
@tmeasday tmeasday changed the base branch from tom/ap-3544-implement-build-of-out-date-behaviour to main September 4, 2023 11:54
@tmeasday tmeasday merged commit 5a822e1 into main Sep 4, 2023
5 of 6 checks passed
@tmeasday tmeasday deleted the tom/ap-3544-implement-build-of-out-date-behaviour-2 branch September 4, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants