Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Move toolbar button to sidebar #77

Merged
merged 3 commits into from
Sep 6, 2023
Merged

UI: Move toolbar button to sidebar #77

merged 3 commits into from
Sep 6, 2023

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Sep 6, 2023 •
edited by tmeasday
Loading

What I did:

  • I changed the manager addon registration so it registers a sidebar-top item, instead of a tool
  • I changed the UI of the component

How to test

  • Open storybook in repo
  • Check if the toolbar button is removed
  • Check if the sidebar shows the play-icon
  • When logging out, or if you haven't selected a project yet, the sidebar Icon should NOT show.
📦 Published PR as canary version: 0.0.56--canary.77.02e49b5.0

✨ Test out this PR locally via:

npm install @chromaui/addon-visual-tests@0.0.56--canary.77.02e49b5.0
# or 
yarn add @chromaui/addon-visual-tests@0.0.56--canary.77.02e49b5.0

@ndelangen ndelangen self-assigned this Sep 6, 2023
@ndelangen ndelangen added the enhancement Classification: Improvement to existing feature label Sep 6, 2023
tmeasday
tmeasday approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but can we get some stories for this component?

@ndelangen
Copy link
Member Author

No problem! I extracted the contents of the components into a separate component and wrote a story describing the 2 states.

We'll add more states as we implement the progress reporting.

@ndelangen ndelangen merged commit 6f21d74 into main Sep 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

@ghengeveld ghengeveld Awaiting requested review from ghengeveld

Assignees

@ndelangen ndelangen

Labels
enhancement Classification: Improvement to existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndelangen @tmeasday