-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open dialog to allow creating a new project #91
Open dialog to allow creating a new project #91
Conversation
AP-3630 Add workflow for creating a new project
|
AP-3620 Ensure project list updates when new projects are created
Currently, if a Chromatic project doesn't already exist it's cumbersome to create a new one and link the Storybook repo to it via the addon Repro
|
…low-for-creating-a-new-project
Copied and adapted with help from @kasperpeulen from #100
The API is slightly more awkward but there's no magic.
@@ -0,0 +1,58 @@ | |||
import { useCallback, useEffect, useRef } from "react"; | |||
import { z } from "zod"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like it's a bit heavy-handed to introduce zod just for this purpose. Do you have other uses in mind?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's already a dependency of the CLI, so I don't think that's a big issue?
Fixes AP-3630
Add a new item to the
LinkProject
list for "create new project" and open a dialog to the apps page of the account, which allows you to create a new project.TODO
TO QA
See https://github.com/chromaui/chromatic/pull/7734
📦 Published PR as canary version:
0.0.83--canary.91.c5d6621.0
✨ Test out this PR locally via:
npm install @chromaui/addon-visual-tests@0.0.83--canary.91.c5d6621.0 # or yarn add @chromaui/addon-visual-tests@0.0.83--canary.91.c5d6621.0