Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open dialog to allow creating a new project #91

Merged
merged 15 commits into from
Sep 19, 2023

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Sep 8, 2023

Fixes AP-3630

Add a new item to the LinkProject list for "create new project" and open a dialog to the apps page of the account, which allows you to create a new project.

image

TODO

TO QA

See https://github.com/chromaui/chromatic/pull/7734

📦 Published PR as canary version: 0.0.83--canary.91.c5d6621.0

✨ Test out this PR locally via:

npm install @chromaui/addon-visual-tests@0.0.83--canary.91.c5d6621.0
# or 
yarn add @chromaui/addon-visual-tests@0.0.83--canary.91.c5d6621.0

@linear
Copy link

linear bot commented Sep 8, 2023

AP-3630 Add workflow for creating a new project

  1. Have a link on projects list ("Don't see your project?..")
  2. Open new window to chromatic.com
  3. After project is created, ensure window closes
  4. You are taken back to successfully linked project screen for new project

@tmeasday tmeasday marked this pull request as draft September 8, 2023 04:57
@linear
Copy link

linear bot commented Sep 11, 2023

AP-3620 Ensure project list updates when new projects are created

Currently, if a Chromatic project doesn't already exist it's cumbersome to create a new one and link the Storybook repo to it via the addon

Repro

  1. Connect chromatic.com (Log in, etc)
  2. At the project picker, switch tabs, go to Chromatic.com and create a new project
  3. Switch back to the visual test addon and notice the project list isn't refreshed.
  4. Restart Storybook, the newly added project is now in the picker

@tmeasday tmeasday changed the title Open dialog to allow creating new account Open dialog to allow creating a new project Sep 11, 2023
@tmeasday tmeasday marked this pull request as ready for review September 18, 2023 13:16
src/screens/LinkProject/LinkProject.tsx Outdated Show resolved Hide resolved
@@ -0,0 +1,58 @@
import { useCallback, useEffect, useRef } from "react";
import { z } from "zod";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like it's a bit heavy-handed to introduce zod just for this purpose. Do you have other uses in mind?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already a dependency of the CLI, so I don't think that's a big issue?

@tmeasday tmeasday merged commit 2333376 into main Sep 19, 2023
6 checks passed
@tmeasday tmeasday deleted the tom/ap-3630-add-workflow-for-creating-a-new-project branch September 19, 2023 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants