Ensure GitHub Action runs in specified version of node #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences🚀 Don’t miss a bit, follow what’s new on Codacy. Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
tevanoff
force-pushed
the
todd/fix-exec-build
branch
from
98e0b88
to
fb8f7b8
Compare
…ning builds with the correct version
Welp, turns out that yarn 4 does NOT enforce the node version specified in engines anymore. So even if we have a version of node set, but yarn is running in a different version of node, the commands won't fail. Without that enforcement, this test won't work. This reverts commit 7539866.
When set to true, this ran the commands with the node version set by the action (node20), not the version set in the workflow.
tevanoff
force-pushed
the
todd/fix-exec-build
branch
from
fb8f7b8
to
6fc55b5
Compare
tevanoff
added
release
ethriel3695
approved these changes
Jun 12, 2024
ghengeveld
reviewed
Jun 12, 2024
ghengeveld
approved these changes
Jun 12, 2024
Co-authored-by: Gert Hengeveld <info@ghengeveld.nl>
tevanoff
force-pushed
the
todd/fix-exec-build
branch
from
eba7ae9
to
710c589
Compare
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert this small bit that was added in #991.
It was not necessary for the change made in that PR, and it caused the Storybook build command to run with the node version specified by the GitHub Action (node 20), instead of the version of node that is installed in the workflow using something like
actions/setup-node.Fixes #1000
Fixes #1002
📦 Published PR as canary version:
11.5.5--canary.1006.9486086143.0✨ Test out this PR locally via:
npm install chromatic@11.5.5--canary.1006.9486086143.0 # or yarn add chromatic@11.5.5--canary.1006.9486086143.0