Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass CI=1 environment variable to Storybook build command to disable prompts #991

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented May 24, 2024

This should prevent the Storybook build script from prompting (e.g. to send a crash report), which would cause the CLI to hang.

As an added bonus, preferLocal might help ensure we use a locally installed package over a global one.

📦 Published PR as canary version: 11.4.1--canary.991.9225753804.0

✨ Test out this PR locally via:

npm install chromatic@11.4.1--canary.991.9225753804.0
# or 
yarn add chromatic@11.4.1--canary.991.9225753804.0

Copy link

linear bot commented May 24, 2024

@ghengeveld ghengeveld changed the title Pass CI=1 environment variable to build-storybook and prefer local binaries Pass CI=1 environment variable to Storybook build command to disable prompts May 24, 2024
Copy link
Member

@thafryer thafryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! We have a few different tickets related to this!

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (24e744c) 8471 6675 78.80%
Head commit (a1375ff) 8472 (+1) 6676 (+1) 78.80% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#991) 2 2 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

@ghengeveld ghengeveld added release Auto: Create a `latest` release when merged patch Auto: Increment the patch version when merged labels May 24, 2024
@ghengeveld ghengeveld added this pull request to the merge queue May 25, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 25, 2024
@ghengeveld ghengeveld added this pull request to the merge queue May 27, 2024
Merged via the queue into main with commit 30c518c May 27, 2024
25 of 27 checks passed
@ghengeveld ghengeveld deleted the ghengeveld/ap-4602-cli-hangs-if-storybook-build-fails-and-prompts-you-for-crash branch May 27, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged release Auto: Create a `latest` release when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants