Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only replace *local* builds with uncommitted changes #994

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented May 31, 2024

Rather than always replacing any baseline builds with uncommitted changes, only apply this behavior to local builds. This restores the original behavior from before v11.4.0 (#988) for non-local builds.

Depends on https://github.com/chromaui/chromatic/pull/8665

Note that this does not require a CLI version bump in the VTA because by definition this update will only affect non-local (i.e. non-VTA) builds.

📦 Published PR as canary version: 11.5.2--canary.994.9355913361.0

✨ Test out this PR locally via:

npm install chromatic@11.5.2--canary.994.9355913361.0
# or 
yarn add chromatic@11.5.2--canary.994.9355913361.0

Copy link

linear bot commented May 31, 2024

@ghengeveld ghengeveld requested a review from tmeasday May 31, 2024 13:02
Copy link

codacy-production bot commented May 31, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for c5e07cf1 100.00% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (c5e07cf) Report Missing Report Missing Report Missing
Head commit (e53dc2d) 8458 6675 78.92%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#994) 9 9 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@ghengeveld ghengeveld added release Auto: Create a `latest` release when merged patch Auto: Increment the patch version when merged labels May 31, 2024
@ghengeveld ghengeveld changed the title Only replace _local_ builds with uncommitted changes Only replace *local* builds with uncommitted changes May 31, 2024
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, makes sense

@ghengeveld ghengeveld added skip-release Auto: Preserve the current version when merged and removed release Auto: Create a `latest` release when merged labels Jun 3, 2024
@ghengeveld ghengeveld added this pull request to the merge queue Jun 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 3, 2024
@ghengeveld ghengeveld added this pull request to the merge queue Jun 3, 2024
Merged via the queue into main with commit 17a6680 Jun 3, 2024
26 checks passed
@ghengeveld ghengeveld deleted the ghengeveld/ap-4668-customers-hit-error-build-had-uncommitted-changes branch June 3, 2024 18:37
@ghengeveld
Copy link
Member Author

🚀 PR was released in v11.5.1 🚀

@ghengeveld ghengeveld added the released Verdict: This issue/pull request has been released label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Auto: Increment the patch version when merged released Verdict: This issue/pull request has been released skip-release Auto: Preserve the current version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants