-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use replacement build for baseline build with uncommitted changes #988
Use replacement build for baseline build with uncommitted changes #988
Conversation
…uncommitted changes
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy will stop sending the deprecated coverage status from June 5th, 2024. Learn more Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a question and a nit.
🚀 PR was released in |
Addresses chromaui/addon-visual-tests#231
Similar to how we use a replacement build as baseline when an ancestor build's commit cannot be found, this will use a replacement build as baseline when the original baseline build had uncommitted changes.
📦 Published PR as canary version:
11.5.0--canary.988.9174965495.0
✨ Test out this PR locally via:
npm install chromatic@11.5.0--canary.988.9174965495.0 # or yarn add chromatic@11.5.0--canary.988.9174965495.0