Update get-started.md #75
Conversation
Modifications made for adaptation to pt-BR translation.
| Irão ser necessárias algumas etapas adicionais de forma a ser possível configurar o processo de compilação no nosso ambiente de desenvolvimento. | ||
| Para começar queremos usar o pacote [Create React App](https://github.com/facebook/create-react-app) ou como é vulgarmente conhecido (CRA), para configurar o nosso ambiente local e ativar o modo de testes com [Storybook](https://storybook.js.org/) e | ||
| [Jest](https://facebook.github.io/jest/) na nossa aplicação. | ||
| Serão necessárias algumas etapas adicionais para que seja possível configurar o processo de compilação em nosso ambiente de desenvolvimento. |
There was a problem hiding this comment.
I agree with almost of the change in here, but replacing "no" with "em", it's unnecessary, this will transform it into a specified version. And not what's intended, it's portuguese in all it's form. Not a specification to pt-BR
| @@ -44,34 +44,34 @@ yarn start | |||
| ``` | |||
|
|
|||
| <div class="aside"> | |||
| Nota: Se <code>yarn test</code> emitir um erro, será necessário instalar o pacote <code>watchman</code>, tal como recomendado neste <a href="https://github.com/facebook/create-react-app/issues/871#issuecomment-252297884">problema</a> | |||
| Nota: Se o comando <code>yarn test</code> produzir um erro, será necessário instalar o pacote <code>watchman</code>, conforme recomendado nesta <a href="https://github.com/facebook/create-react-app/issues/871#issuecomment-252297884">thread</a> | |||
There was a problem hiding this comment.
Why change the "problema" para "thread"? It's best to leave it as is. Both audiences can read it perfectly and understand the meaning. The rest of the phrase looks good.
There was a problem hiding this comment.
This link refers to yarn but is not a specific problem of it.
The main problem is about the npm and in the middle of the thread they talk about the yarn.
There was a problem hiding this comment.
The main problem is about the npm and in the middle of the thread they talk about the yarn.
This phrase exists, due to the fact that the guide is heavily influenced by Create React App and with that as they are much more prone to using yarn as opposed to npm, for reasons that are out of the scope of this guide. The writter left in that note. That sentence is being corrected to allow it both ways. Using npm or yarn
|
i know i'm new here, but i would like to add my two cents in this matter. Left some revisions on the code so that the translation can be done in a uniform manner |
| Irá ser necessário adicionar também as pastas com o tipo de letra e ícones que se encontram disponíveis [aqui](https://github.com/hichroma/learnstorybook-code/tree/master/public) á pasta `public`. Ao adicionar estes elementos, a aplicação irá renderizar de forma algo estranha. | ||
| Mas isto é de esperar, visto que não iremos trabalhar na aplicação agora. | ||
| Será necessário adicionar também as pastas com o tipo de letra e icones que se encontram disponíveis [aqui](https://github.com/hichroma/learnstorybook-code/tree/master/public) à pasta `public`. Ao adicionar estes elementos, a aplicação irá renderizar de forma um pouco estranha. | ||
| Mas isto é esperado, visto que não iremos trabalhar na aplicação agora. |
There was a problem hiding this comment.
Phrasing sounds pretty much perfectly clear for all. Also "ícones" is well written. There's an accent in there
There was a problem hiding this comment.
Sorry, it's just a grammatical correction related to the verbs "ir" and "ser".
|
@sarmentof is this issue still active? We're updating the guide this month and want to clear out stuff that's no longer active. 🙏 |
Modifications made for adaptation to pt-BR translation.