Add proper support for :not() #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-akinc
commented
Apr 15, 2024
m-akinc
commented
Apr 15, 2024
m-akinc
commented
Apr 15, 2024
m-akinc
commented
Apr 15, 2024
|
@ghengeveld after this PR, I also have a change that adds support for |
ghengeveld
added
patch
|
@ghengeveld seems like this stalled out. Anything I can do to help? |
|
@m-akinc We had a company retreat last week so I was preoccupied. I'll take a look soon. |
|
Dang, seems like this broke a bunch of stories. Could you check it out @m-akinc? Perhaps address it in that follow-up PR? |
@ghengeveld Sorry for that! Fix is up in #117. Another PR adding support for |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code avoided generating invalid CSS when a rule included
:not(), but it did not provide correct support for thepseudo-*-allclasses. For example,:not(:hover)would be transformed to.pseudo-hover-all :not(), but we would skip writing that rule, because of the invalid (i.e. empty):not(). The correct rewriting of that rule is:not(.pseudo-hover-all *), i.e. "Not a descendant of an element with class.pseudo-hover-all". Similarly, for shadow DOM styles, we need special logic to turn the example rule into:not(:host(.pseudo-hover-all) *).In general, the approach is:
:not(...<pseudo-state>...)with:not(.pseudo-<state>-all ...)(or:not(:host(.pseudo-<state>-all) ...)if for shadow DOM)...<pseudo-state>...->.pseudo-<state>-all ...Additionally, the refactoring I did allowed the removal of special logic related to
::slotted()and:has().