Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support :host-context() selector #118

Merged
merged 2 commits into from
May 6, 2024

Conversation

m-akinc
Copy link
Contributor

@m-akinc m-akinc commented May 2, 2024

:host-context() works like :host() except that it selects based on the host element's ancestors. So in replacePseudoStatesWithAncestorSelector, if :host-context() is part of the selector, we append the class selectors to it instead of prepending a :host() selector with them.

@m-akinc
Copy link
Contributor Author

m-akinc commented May 3, 2024

@ghengeveld I think after this goes in, it's release time. 🚀

@ghengeveld ghengeveld added minor Increment the minor version when merged release Create a `latest` release when merged labels May 6, 2024
@ghengeveld ghengeveld self-requested a review May 6, 2024 10:58
Copy link
Member

@ghengeveld ghengeveld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Including the stories this time 😄

@ghengeveld ghengeveld merged commit a5ea4c7 into chromaui:main May 6, 2024
1 check passed
Copy link

github-actions bot commented May 6, 2024

🚀 PR was released in v3.1.0 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged release Create a `latest` release when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants