Skip to content

Commit

Permalink
Minor cleanup to CI
Browse files Browse the repository at this point in the history
  • Loading branch information
kenshaw committed Apr 27, 2021
1 parent fc4b19c commit 62fe0f9
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 23 deletions.
27 changes: 7 additions & 20 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,32 +2,19 @@ on: [push, pull_request]
name: Test
jobs:
test:
strategy:
matrix:
go-version: [1.16.x]
# We want testing.T.Cleanup for parallel subtests.
# go-version: [1.13.x, 1.16.x]
# TODO: Add macos-latest and windows-latest. The former doesn't come
# with Chrome by default, and the latter needs lots of work in the tests.
platform: [ubuntu-latest]
runs-on: ${{ matrix.platform }}
steps:
- name: Install Go
uses: actions/setup-go@v2
with:
go-version: ${{ matrix.go-version }}
- name: Checkout code
uses: actions/checkout@v2
- name: Test
run: TMPDIR=$RUNNER_TEMP go test -v ./...
test-headless-shell:
runs-on: ubuntu-latest
steps:
- name: Install Go
uses: actions/setup-go@v2
with:
go-version: 1.16.x
- name: Install Packages
run: |
sudo apt-get -qq update
sudo apt-get install -y build-essential
- name: Checkout code
uses: actions/checkout@v2
- name: Test
run: ./contrib/docker-test.sh
run: |
TMPDIR=$RUNNER_TEMP go test -v ./...
./contrib/docker-test.sh
9 changes: 7 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
# About chromedp [![Go Reference][goref-chromedp-status]][goref-chromedp]
# About chromedp

Package chromedp is a faster, simpler way to drive browsers supporting the
Package `chromedp` is a faster, simpler way to drive browsers supporting the
[Chrome DevTools Protocol][devtools-protocol] in Go without external dependencies.

[![Unit Tests][chromedp-ci-status]][chromedp-ci]
[![Go Reference][goref-chromedp-status]][goref-chromedp]

## Installing

Install in the usual Go way:
Expand Down Expand Up @@ -73,6 +76,8 @@ to find out of the box.
* [`github.com/chromedp/pdlgen`][chromedp-pdlgen] - tool used to generate `cdproto`
* [`github.com/chromedp/chromedp-proxy`][chromedp-proxy] - a simple CDP proxy for logging CDP clients and browsers

[chromedp-ci]: https://github.com/chromedp/chromedp/actions/workflows/test.yml (Test CI)
[chromedp-ci-status]: https://github.com/chromedp/chromedp/actions/workflows/test.yml/badge.svg (Test CI)
[chromedp-examples]: https://github.com/chromedp/examples
[chromedp-pdlgen]: https://github.com/chromedp/pdlgen
[chromedp-proxy]: https://github.com/chromedp/chromedp-proxy
Expand Down
2 changes: 1 addition & 1 deletion contrib/docker-test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ pushd $SRC &> /dev/null
set -e

(set -x;
go test -c
CGO_ENABLED=0 go test -c
)

(set -x;
Expand Down

0 comments on commit 62fe0f9

Please sign in to comment.